[PATCH] Properly retry package downloads (#924860)

Martin Kolman mkolman at redhat.com
Mon Feb 10 12:19:31 UTC 2014


On Fri, 2014-02-07 at 13:27 -0500, Chris Lumens wrote:
> > There are basically two cases where package download can fail:
> > - when YUM is populating the transaction
> >   (this actually just checks the file exists)
> > - when the transaction is started and packages are downloaded and
> >   installed
> > 
> > Previously Anaconda did not attempt to retry the first one at all
> > and made an unlimited number of attempts in the second one.
> > 
> > This has been changed and Anaconda now does 3 retries separated
> > by 3 seconds of waiting in both cases.
> 
> Way back in the day, we tried to be smart about retrying with something
> like the following:  9593841564a29155821c47dc48ae27cd2f666aa9.  However,
> that was when we were retrying (I think) 10 times.  I just wanted to
> bring this up in case you'd thought about doing such a thing.  It
> doesn't really matter to me how long we try.
That's a really good point - for people with good connectivity the
retry duration actually does not matter at all (they will get everything
on the first try).
But for people with a really spotty connection, even if it makes the
installation twice as long (for example), it will still be faster than
running the installation over and over again.
I was thinking about using the 3 tries and 3 seconds in between as used
in RHEL6 and changing it if we get reports that is is not enough.
Now I think I'll do the opposite - I'll change it to 10 tries & "smart
waiting" and we can still change it later if we get reports it retries
for too long.
> 
> Looks fine to me.
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list