[PATCH rhel7-branch] Allow specifying an environment in the kickstart file (#1050994).

Vratislav Podzimek vpodzime at redhat.com
Wed Feb 5 07:23:47 UTC 2014


On Tue, 2014-02-04 at 11:43 -0500, Chris Lumens wrote:
> ---
>  anaconda.spec.in                     | 2 +-
>  pyanaconda/packaging/yumpayload.py   | 2 ++
>  pyanaconda/ui/gui/spokes/software.py | 2 ++
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/anaconda.spec.in b/anaconda.spec.in
> index a968ecd..fd5028d 100644
> --- a/anaconda.spec.in
> +++ b/anaconda.spec.in
> @@ -21,7 +21,7 @@ Source0: %{name}-%{version}.tar.bz2
>  %define gconfversion 2.28.1
>  %define intltoolver 0.31.2-3
>  %define libnlver 1.0
> -%define pykickstartver  1.99.43.4
> +%define pykickstartver  1.99.43.8
>  %define yumver 3.4.3-91
>  %define partedver 1.8.1
>  %define pypartedver 2.5-2
> diff --git a/pyanaconda/packaging/yumpayload.py b/pyanaconda/packaging/yumpayload.py
> index 4b4a226..3cff8eb 100644
> --- a/pyanaconda/packaging/yumpayload.py
> +++ b/pyanaconda/packaging/yumpayload.py
> @@ -1367,6 +1367,8 @@ reposdir=%s
>  
>          if self.data.packages.default and self.environments:
>              self.selectEnvironment(self.environments[0])
> +        elif self.data.packages.environment:
> +            self.selectEnvironment(self.data.packages.environment)
Shouldn't self.data.packages.environment have a higher priority than
self.data.packages.default? I believe users would expect the code to
behave this way.

Otherwise these both look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list