[PATCH 2/2] Add a sidebar to the standalone and hub windows (#1045250)

Máirín Duffy duffy at redhat.com
Wed Feb 5 00:19:57 UTC 2014


On 02/04/2014 03:57 PM, Chris Lumens wrote:
> The -logo files will be coming out of a product.img, I assume?

I'm not sure, where did they used to get shipped? I attached them to the 
bug.

> What are
> the odds we can just ensure the file is always the same name and not
> have to worry about different classes for different products?

Oh yes, very smart. Sorry about that. Making the filename the same makes 
sense; the reason there are two styles was primarily because the 
background color will change (will be blue for Fedora without texture.) 
So I re-did the CSS so you just have to flip the color and texture 
settings in just that file.

1
> Stylistically, I'm picky.  I like whitespace.  I'd like to see a newline
> here.

2
> And this as 0.18.  It just looks weird without.

3
> This function is only used in this file, yeah?  So it could be static.

4
> I know gcc doesn't require it, but I like variables defined before they
> start getting used.  Old school, I guess.

5
> Please indent the part under the if.

6
> Please add a newline here.

7
> And put spaces around the = operators here.

8
> And then all the same comments apply to this file too.

Okay, I have an updated version of the patch that address everything in 
1-8 as well as makes the image names more generic.

> I assume you've also checked tty1 to make sure there's no relevant
> gtk/glib/whatever assertions.  Sometimes those are hiding there.

Checked it and it's surprisingly bare! :)

Will re-submit in a separate email.

~m


More information about the anaconda-patches mailing list