[blivet:master 0/6] Some patches for formats package.

mulhern amulhern at redhat.com
Wed Dec 17 14:33:42 UTC 2014


Things I ran across while working on tasks refactoring.

Use correct package... is dead obvious. Tests never hit it, because there
is a guard in writeLabel() that prevents that code path from executing.
Pylint never saw it because of the unfortunate choice of fs for a parameter.
Both of those problems should be fixed, but they already are as a side-effect 
of other changes in my tasks branch, and I don't want any more rebasing
headaches. 
Change allowDirty to False...is a no brainer.
Eliminate dirtyCB parameter...should not be too controversial and makes
next patch a bit easier.
Factor out calculation...shouldn't be too hard to accept.

The last two are really desirable as they ease refactoring in my tasks branch
a good deal. Otherwise, I get to spend a lot of time disentanglishing dirty
calculation from minimum size calculation, and if those dirty and error
values are never used, as they aren't in existing anaconda set up, that
would be a depressing task.

mulhern (6):
  Use correct package for FSError.
  Change allowDirty to False (from None).
  Eliminate dirtyCB parameter from mountExistingSystem() params.
  Factor out calculation of dirtyDevices and be less eager in
    calculating.
  Remove allowDirty parameter and dependent code.
  Remove needsFSCheck() and what only it depends on.

 blivet/__init__.py              | 27 +--------------------------
 blivet/formats/fs.py            | 21 ---------------------
 blivet/formats/fslabel.py       |  2 +-
 tests/formats_test/fstesting.py |  1 -
 4 files changed, 2 insertions(+), 49 deletions(-)

-- 
1.9.3



More information about the anaconda-patches mailing list