[master/rhel7-branch 2/2] Fix the way we create the list of DASDs needing dasdfmt. (#1073982)
Brian C. Lane
bcl at redhat.com
Fri Dec 12 22:44:00 UTC 2014
On Fri, Dec 12, 2014 at 03:44:03PM -0500, Samantha N. Bueno wrote:
> selected_disks is nice and all, but if you don't explicitly state in
> your ks file which disks you're using (in other words, use them all),
> selected_disks is always going to be an empty list. Then if any of
> them need dasdfmt, they won't get it, since we pass selected_disks
> to the function determining which DASDs need dasdfmt.
>
> So, just pass storage.devicetree to determine which DASDs need
> dasdfmt--this is what's done in the GUI also. Yet another TUI
> discrepancy done away with.
>
> Related: rhbz#1073982
> ---
> pyanaconda/ui/tui/spokes/storage.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pyanaconda/ui/tui/spokes/storage.py b/pyanaconda/ui/tui/spokes/storage.py
> index 718e1f6..528d371 100644
> --- a/pyanaconda/ui/tui/spokes/storage.py
> +++ b/pyanaconda/ui/tui/spokes/storage.py
> @@ -84,7 +84,7 @@ class StorageSpoke(NormalTUISpoke):
> if self.data.zerombr.zerombr and arch.isS390():
> # if zerombr is specified in a ks file and there are unformatted
> # dasds, automatically format them
> - to_format = make_unformatted_dasd_list(self.selected_disks)
> + to_format = make_unformatted_dasd_list(d.name for d in getDisks(self.storage.devicetree))
> if to_format:
> self.run_dasdfmt(to_format)
>
> --
> 1.8.3.1
Ack
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
More information about the anaconda-patches
mailing list