[master/rhel7-branch 1/2] Fix threading issues for dasdfmt in gui storage. (#1073982)

Brian C. Lane bcl at redhat.com
Fri Dec 12 22:43:40 UTC 2014


On Fri, Dec 12, 2014 at 03:43:54PM -0500, Samantha N. Bueno wrote:
> Prior code I committed manually issued a call to spoke.execute()
> in the storage spoke once dasdfmt had been run (if doing a ks
> installation). Turns out this is a Bad Idea. spoke.execute() is
> called anyway from pyanaconda.ui.gui.hubs once it is detected that
> a spoke has changed, so this is not necessary.
> 
> Resolves: rhbz#1073982
> ---
>  pyanaconda/ui/gui/spokes/storage.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
> index 874e3e3..a8c269e 100644
> --- a/pyanaconda/ui/gui/spokes/storage.py
> +++ b/pyanaconda/ui/gui/spokes/storage.py
> @@ -717,10 +717,6 @@ class StorageSpoke(NormalSpoke, StorageChecker):
>                  log.error(str(err))
>                  continue
>  
> -        # I really hate doing this, but the way is the way; probably the most
> -        # correct way to kajigger the storage spoke into becoming ready
> -        self.execute()
> -
>      # signal handlers
>      def on_summary_clicked(self, button):
>          # show the selected disks dialog
> -- 
> 1.8.3.1

Ack

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list