[PATCH 2/3] Remove the color override from MountpointSelector.

David Shea dshea at redhat.com
Wed Dec 10 14:33:06 UTC 2014


On 12/10/2014 02:47 AM, Vratislav Podzimek wrote:
> On Tue, 2014-12-09 at 15:47 -0500, David Shea wrote:
>> I don't think this does anything? It doesn't look like it does anything.
>> ---
>>   widgets/src/MountpointSelector.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/widgets/src/MountpointSelector.c b/widgets/src/MountpointSelector.c
>> index a9ad215..a38d97a 100644
>> --- a/widgets/src/MountpointSelector.c
>> +++ b/widgets/src/MountpointSelector.c
>> @@ -299,13 +299,9 @@ static void anaconda_mountpoint_selector_set_property(GObject *object, guint pro
>>   static void anaconda_mountpoint_selector_toggle_background(AnacondaMountpointSelector *widget) {
>>       if (widget->priv->chosen) {
>>           gtk_widget_set_state_flags(GTK_WIDGET(widget), GTK_STATE_FLAG_SELECTED, FALSE);
>> -        gtk_widget_override_color(GTK_WIDGET(widget->priv->mountpoint_label), GTK_STATE_FLAG_SELECTED, NULL);
>>       }
>>       else {
>> -        GdkRGBA color;
>>           gtk_widget_unset_state_flags(GTK_WIDGET(widget), GTK_STATE_FLAG_SELECTED);
>> -        gdk_rgba_parse(&color, "#555555");
>> -        gtk_widget_override_color(GTK_WIDGET(widget->priv->mountpoint_label), GTK_STATE_FLAG_NORMAL, &color);
>>       }
>>   }
> I believe this used to make the widget looking as selected even if it
> lost focus. I remember doing some changes in that, but I cannot tell now
> if this is really not necessary anymore. Just please test the case where
> you have a mountpoint selected and then click (move focus) on some
> widget in the right size (e.g. Label).
>

It stays selected (blue) both with and without the change. Since the 
color being set pre-patch is more grayish (maybe to make it look 
selected but not active?), I'm not sure that this is the intent, but 
looking back at Fedora 20 and 19 (which both just unselect it 
completely) I'm not sure that our intent has ever once worked.


More information about the anaconda-patches mailing list