[blivet:master] Include "ntfs" explicitly among unsupported filesystems.

Anne Mulhern amulhern at redhat.com
Tue Dec 9 20:47:48 UTC 2014





----- Original Message -----
> From: "Brian C. Lane" <bcl at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Tuesday, December 9, 2014 2:44:51 PM
> Subject: Re: [blivet:master] Include "ntfs" explicitly among unsupported	filesystems.
> 
> On Tue, Dec 09, 2014 at 10:38:28AM -0500, mulhern wrote:
> > Previously, it was excluded from supported filesystems implicitly,
> > by means of the formattable attribute, which was always false for ntfs.
> > 
> > This does not change the behavior of anaconda at all, but allows more
> > consistent management of filesystems in blivet.
> > 
> > Signed-off-by: mulhern <amulhern at redhat.com>
> > ---
> >  pyanaconda/ui/gui/spokes/custom.py | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/pyanaconda/ui/gui/spokes/custom.py
> > b/pyanaconda/ui/gui/spokes/custom.py
> > index fca7f3f..e8ad559 100644
> > --- a/pyanaconda/ui/gui/spokes/custom.py
> > +++ b/pyanaconda/ui/gui/spokes/custom.py
> > @@ -286,11 +286,10 @@ class CustomPartitioningSpoke(NormalSpoke,
> > StorageChecker):
> >              obj = cls()
> >  
> >              # btrfs is always handled by on_device_type_changed
> > -            supported_fs = (obj.type != "btrfs" and
> > -                            obj.type != "tmpfs" and
> > +            supported_fs = (obj.type not in ("btrfs", "ntfs", "tmpfs") and
> >                              obj.supported and obj.formattable and
> >                              (isinstance(obj, FS) or
> > -                             obj.type in ["biosboot", "prepboot",
> > "swap"]))
> > +                             obj.type in ("biosboot", "prepboot",
> > "swap")))
> >              if supported_fs:
> >                  self._fs_types.append(obj.name)
> >  
> > --
> > 1.9.3
> 
> Ack.
> 
> Does anything specific need to be done for kickstart?
> 
> --
> Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA
> (PST8PDT)
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

I think not. I don't think any restrictions on specified filesystem types
are enforced in kickstart.py at this time.

- mulhern


More information about the anaconda-patches mailing list