[blivet][master/rhel7-branch] Make sure bootDevice is not LVM LV if we're on s390x (#873135)

Samantha N. Bueno sbueno+anaconda at redhat.com
Tue Dec 9 20:14:44 UTC 2014


On Tue, Dec 09, 2014 at 08:41:42AM -0800, Adam Williamson wrote:
> On Mon, 2014-12-08 at 16:35 -0500, Samantha N. Bueno wrote:
> > For whatever reason, during s390x ks installations, if you tried to
> > set /boot on LVM, it would be allowed. Well, don't allow it.
> 
> Just out of curiosity - a few of these 'if arch' bits seem to be showing
> up lately, but platform.py has this in the Platform docstring:
> 
> "The intent is to eventually encapsulate all the architecture quirks in
> one place to avoid lots of platform checks throughout anaconda."
> 
> has that intent changed, or should these kinds of things be going into
> platform.py?

(a) s390x is a special beast requiring special treatment at times.
Furthermore, AFAIK the intent you cite is still the same, but it is not
always possible to keep arch-specific checks only in platform.py due to
various constraints.

(b) For rhel7-branch sometimes it is better to do what is simpler and
low-risk rather than what is most correct, especially when taking into
account where we are in the schedule. Case in point.

Samantha


More information about the anaconda-patches mailing list