[master/rhel7-branch] Take II: Make sure /boot is not LVM LV if we're on s390x (#873135)

Brian C. Lane bcl at redhat.com
Tue Dec 9 19:45:51 UTC 2014


On Tue, Dec 09, 2014 at 11:36:28AM -0500, Samantha N. Bueno wrote:
> During s390x ks installations, if you had explicitly defined partitions
> and decided to put /boot on LVM, it would be allowed. Well, don't allow
> it.
> 
> Resolves: rhbz#873135
> ---
>  pyanaconda/kickstart.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> index 4122c02..1e5b993 100644
> --- a/pyanaconda/kickstart.py
> +++ b/pyanaconda/kickstart.py
> @@ -775,6 +775,11 @@ class LogVolData(commands.logvol.RHEL7_LogVolData):
>  
>          storage.doAutoPart = False
>  
> +        # FIXME: we should be running sanityCheck on partitioning that is not ks
> +        # autopart, but that's likely too invasive for #873135 at this moment
> +        if self.mountpoint == "/boot" and blivet.arch.isS390():
> +            raise KickstartValueError(formatErrorMsg(self.lineno, msg="/boot can not be of type 'lvmlv' on s390x"))
> +
>          # we might have truncated or otherwise changed the specified vg name
>          vgname = ksdata.onPart.get(self.vgname, self.vgname)
>  
> -- 
> 1.8.3.1

Ack

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list