[master/rhel7-branch] Take II: Make sure /boot is not LVM LV if we're on s390x (#873135)

Anne Mulhern amulhern at redhat.com
Tue Dec 9 19:42:29 UTC 2014





----- Original Message -----
> From: "Samantha N. Bueno" <sbueno+anaconda at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Tuesday, December 9, 2014 11:36:28 AM
> Subject: [master/rhel7-branch] Take II: Make sure /boot is not LVM LV if we're	on s390x (#873135)
> 
> During s390x ks installations, if you had explicitly defined partitions
> and decided to put /boot on LVM, it would be allowed. Well, don't allow
> it.
> 
> Resolves: rhbz#873135
> ---
>  pyanaconda/kickstart.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> index 4122c02..1e5b993 100644
> --- a/pyanaconda/kickstart.py
> +++ b/pyanaconda/kickstart.py
> @@ -775,6 +775,11 @@ class LogVolData(commands.logvol.RHEL7_LogVolData):
>  
>          storage.doAutoPart = False
>  
> +        # FIXME: we should be running sanityCheck on partitioning that is
> not ks
> +        # autopart, but that's likely too invasive for #873135 at this
> moment
> +        if self.mountpoint == "/boot" and blivet.arch.isS390():
> +            raise KickstartValueError(formatErrorMsg(self.lineno, msg="/boot
> can not be of type 'lvmlv' on s390x"))
> +
>          # we might have truncated or otherwise changed the specified vg name
>          vgname = ksdata.onPart.get(self.vgname, self.vgname)
>  
> --
> 1.8.3.1
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Looks good to me.

- mulhern


More information about the anaconda-patches mailing list