[blivet][master/rhel7-branch] Make sure bootDevice is not LVM LV if we're on s390x (#873135)

Anne Mulhern amulhern at redhat.com
Tue Dec 9 13:13:14 UTC 2014


I think that this code change should probably be in
pyanaconda.kickstart.Bootloader.execute(), not in Blivet.setUpBootloader().

Also, since it's not just a kickstart but also a GUI bug, it might be good to
also edit custom.CustomPartitioningSpoke._validateMountpoint()...or wherever
that code is in RHEL7.

- mulhern

----- Original Message -----
> From: "Samantha N. Bueno" <sbueno+anaconda at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Monday, December 8, 2014 4:35:46 PM
> Subject: [blivet][master/rhel7-branch] Make sure bootDevice is not LVM LV if	we're on s390x (#873135)
> 
> For whatever reason, during s390x ks installations, if you tried to
> set /boot on LVM, it would be allowed. Well, don't allow it.
> 
> Resolves: rhbz#873135
> ---
>  blivet/__init__.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/blivet/__init__.py b/blivet/__init__.py
> index 483f97d..d410bb3 100644
> --- a/blivet/__init__.py
> +++ b/blivet/__init__.py
> @@ -1820,6 +1820,10 @@ class Blivet(object):
>              log.info("user specified that bootloader install be skipped")
>              return
>  
> +        # Make sure bootDevice is not LVM LV if we're on s390x
> +        if arch.isS390() and self.bootDevice.type == "lvmlv":
> +            raise StorageError("/boot can not be of type 'lvmlv' on s390x")
> +
>          # Need to make sure bootDrive has been setup from the latest
>          information
>          self.ksdata.bootloader.execute(self, self.ksdata, None)
>          self.bootloader.stage1_disk =
>          self.devicetree.resolveDevice(self.ksdata.bootloader.bootDrive)
> --
> 1.8.3.1
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list