[blivet][master/rhel7-branch] Make sure bootDevice is not LVM LV if we're on s390x (#873135)

Vratislav Podzimek vpodzime at redhat.com
Tue Dec 9 07:52:32 UTC 2014


On Mon, 2014-12-08 at 16:35 -0500, Samantha N. Bueno wrote:
> For whatever reason, during s390x ks installations, if you tried to
> set /boot on LVM, it would be allowed. Well, don't allow it.
> 
> Resolves: rhbz#873135
> ---
>  blivet/__init__.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/blivet/__init__.py b/blivet/__init__.py
> index 483f97d..d410bb3 100644
> --- a/blivet/__init__.py
> +++ b/blivet/__init__.py
> @@ -1820,6 +1820,10 @@ class Blivet(object):
>              log.info("user specified that bootloader install be skipped")
>              return
>  
> +        # Make sure bootDevice is not LVM LV if we're on s390x
> +        if arch.isS390() and self.bootDevice.type == "lvmlv":
> +            raise StorageError("/boot can not be of type 'lvmlv' on s390x")
> +
>          # Need to make sure bootDrive has been setup from the latest information
>          self.ksdata.bootloader.execute(self, self.ksdata, None)
>          self.bootloader.stage1_disk = self.devicetree.resolveDevice(self.ksdata.bootloader.bootDrive)
Looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list