[blivet:rhel7:master 1/3] Change allow_degraded_mdraid flag to allow_imperfect_devices (#1090009)

Brian C. Lane bcl at redhat.com
Thu Dec 4 18:19:59 UTC 2014


On Wed, Dec 03, 2014 at 02:33:06PM -0500, mulhern wrote:
>          self.update_from_boot_cmdline()
> -        self.allow_degraded_mdraid = True
> +        self.allow_imperfect_devices = True
>  
>      def get_boot_cmdline(self):
>          buf = open("/proc/cmdline").read().strip()
> @@ -101,7 +101,7 @@ class Flags(object):
>          self.gpt = anaconda_flags.gpt
>  
>          self.multipath_friendly_names = anaconda_flags.mpathFriendlyNames
> -        self.allow_degraded_mdraid = anaconda_flags.rescue_mode
> +        self.allow_imperfect_devices = anaconda_flags.rescue_mode
>  
>          self.ibft = anaconda_flags.ibft
>          self.dmraid = anaconda_flags.dmraid

I'd go the other direction and make it default to False. Users that want
to allow degraded devices can set it themselves.

I'd also make anaconda handle setting it instead of adding another
use of anaconda flags in blivet. Hopefully at some point we can remove
all of these and have anaconda setup blivet like every other user of the
library.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list