[initial-setup 0/2] pylinting initial-setup patches

Anne Mulhern amulhern at redhat.com
Thu Dec 4 16:12:26 UTC 2014





----- Original Message -----
> From: "Chris Lumens" <clumens at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Thursday, December 4, 2014 10:51:26 AM
> Subject: Re: [initial-setup 0/2] pylinting initial-setup patches
> 
> > ************* Module initial_setup/tui/hubs/initial_setup_hub.py
> > initial_setup/tui/hubs/initial_setup_hub.py:19:
> > [W9902(found-_-in-module-class), InitialSetupMainHub] Found _ call at
> > module/class level
> > initial_setup/tui/hubs/initial_setup_hub.py:21:
> > [W9902(found-_-in-module-class), InitialSetupMainHub] Found _ call at
> > module/class level
> 
> These should just be changed to N_.  What's going to happen right now is
> that the strings are going to be translated when the file is imported,
> in whatever language is set at the time.  This may not be the language
> that will be displayed to the user.  Elsewhere in anaconda, we will call
> _() on the title at the appropriate time.
> 
> > ************* Module initial_setup/__main__.py
> > initial_setup/__main__.py:142: [E1101(no-member), ] Instance of
> > 'AnacondaKSHandler' has no 'keyboard' member
> > initial_setup/__main__.py:142: [E1101(no-member), ] Instance of
> > 'AnacondaKSHandler' has no 'lang' member
> > initial_setup/__main__.py:142: [E1101(no-member), ] Instance of
> > 'AnacondaKSHandler' has no 'timezone' member
> > initial_setup/__main__.py:159: [E1101(no-member), ] Instance of
> > 'AnacondaKSHandler' has no 'group' member
> > initial_setup/__main__.py:159: [E1101(no-member), ] Instance of
> > 'AnacondaKSHandler' has no 'user' member
> > initial_setup/__main__.py:159: [E1101(no-member), ] Instance of
> > 'AnacondaKSHandler' has no 'rootpw' member
> 
> I don't know what's going on with these, but if initial_setup is running
> properly then I suppose it's a pylint bug.  It may just not be smart
> enough to see through the definition of AnacondaKSHandler in
> pyanaconda/kickstart.py.
> 
> So if it's working fine, I'd say just add a comment to have pylint
> ignore them.
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

OK. I'll just go ahead and fix up those two as recommended,
for pylint-cleanliness.

- mulhern


More information about the anaconda-patches mailing list