[initial-setup 0/2] pylinting initial-setup patches

Vratislav Podzimek vpodzime at redhat.com
Thu Dec 4 14:43:01 UTC 2014


On Thu, 2014-12-04 at 09:32 -0500, mulhern wrote:
> Leaving the harder pylint errors for somebody who's more familiar w/
> initial-setup (and pylint behaviors wrt. pykickstart).
> 
> ************* Module initial_setup/tui/hubs/initial_setup_hub.py
> initial_setup/tui/hubs/initial_setup_hub.py:19: [W9902(found-_-in-module-class), InitialSetupMainHub] Found _ call at module/class level
> initial_setup/tui/hubs/initial_setup_hub.py:21: [W9902(found-_-in-module-class), InitialSetupMainHub] Found _ call at module/class level
> ************* Module initial_setup/__main__.py
> initial_setup/__main__.py:142: [E1101(no-member), ] Instance of 'AnacondaKSHandler' has no 'keyboard' member
> initial_setup/__main__.py:142: [E1101(no-member), ] Instance of 'AnacondaKSHandler' has no 'lang' member
> initial_setup/__main__.py:142: [E1101(no-member), ] Instance of 'AnacondaKSHandler' has no 'timezone' member
> initial_setup/__main__.py:159: [E1101(no-member), ] Instance of 'AnacondaKSHandler' has no 'group' member
> initial_setup/__main__.py:159: [E1101(no-member), ] Instance of 'AnacondaKSHandler' has no 'user' member
> initial_setup/__main__.py:159: [E1101(no-member), ] Instance of 'AnacondaKSHandler' has no 'rootpw' member
> 
> mulhern (2):
>   Add pylint testing infrastructure.
>   Fix easy pylint errors.
> 
>  .gitignore                          |   1 +
>  initial_setup/__main__.py           |  12 +-
>  initial_setup/gui/gui.py            |   6 +-
>  initial_setup/tui/tui.py            |   4 -
>  tests/lib/testlib.sh                |  37 ++++++
>  tests/pylint/intl.py                |  63 +++++++++
>  tests/pylint/pointless-override.py  | 252 ++++++++++++++++++++++++++++++++++++
>  tests/pylint/pylint-false-positives |   0
>  tests/pylint/pylint-one.sh          |  33 +++++
>  tests/pylint/runpylint.sh           | 125 ++++++++++++++++++
>  tests/testenv.sh                    |  13 ++
>  11 files changed, 531 insertions(+), 15 deletions(-)
>  create mode 100644 tests/lib/testlib.sh
>  create mode 100644 tests/pylint/intl.py
>  create mode 100644 tests/pylint/pointless-override.py
>  create mode 100644 tests/pylint/pylint-false-positives
>  create mode 100755 tests/pylint/pylint-one.sh
>  create mode 100755 tests/pylint/runpylint.sh
>  create mode 100644 tests/testenv.sh
These two look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list