RFC: [PATCH] Add --includepkg argument

Brian C. Lane bcl at redhat.com
Wed Dec 3 23:22:46 UTC 2014


On Wed, Nov 26, 2014 at 04:11:51PM -0500, Colin Walters wrote:
> Let me follow up on this a bit more.  This isn't a patch mail, maybe the best list is anaconda-devel, but eh.
> 
> I'm working on https://github.com/projectatomic/fedora-productimg-atomic
> 
> I see lorax is generating an images/product.img that has the right content:
> 
> # xzcat scratch/installer/images/product.img |cpio --list
> .
> usr
> usr/share
> usr/share/anaconda
> usr/share/anaconda/pixmaps
> usr/share/anaconda/pixmaps/topbar-bg.png
> usr/share/anaconda/pixmaps/sidebar-logo_flavor.png
> usr/share/anaconda/pixmaps/sidebar-bg.png
> tmp
> tmp/product
> tmp/product/pyanaconda
> tmp/product/pyanaconda/installclasses
> tmp/product/pyanaconda/installclasses/installclass_atomic.pyo
> tmp/product/pyanaconda/installclasses/installclass_atomic.pyc
> tmp/product/pyanaconda/installclasses/installclass_atomic.py
> usr/share/anaconda/anaconda-gtk.css
> 18 blocks
> 
> However...I don't see this being applied on the installer image by default.   The data is of course in /usr/share/lorax (which we should remove, right?)
> 
> I do see:
> 2014-11-26 20:55:57,689: Creating image file /srv/fedora-atomic/scratch/installer/images/product.img from contents of /var/tmp/lorax.elnT75/installroot/usr/share/lorax//product/
> 
> But, looking at program.log:
> 
> Running... mkisofs -o /srv/fedora-atomic/lorax/output/images/boot.iso -b isolinux/isolinux.bin -c isolinux/boot.cat -boot-load-size 4 -boot-info-table -no-emul-boot -eltorito-alt-boot -e images/efiboot.img -no-e
> mul-boot -R -J -V Fedora Atomic rawhide x86_64 -T -graft-points isolinux=/srv/fedora-atomic/lorax/output/isolinux images/pxeboot=/srv/fedora-atomic/lorax/output/images/pxeboot LiveOS=/srv/fedora-atomic/lorax/out
> put/LiveOS EFI/BOOT=/srv/fedora-atomic/lorax/output/EFI/BOOT images/efiboot.img=/srv/fedora-atomic/lorax/output/images/efiboot.img
> 
> Note the lack of the expected imggraft variable here.  Is it something like that variable is scoped only to the %endfor?
> 
> I'll debug this a bit more at some point, probably Sunday.  Just sending out a status here.

You're using a custom template for atomic, right? You need to add the
new template code from commit ac6e4a29c3a6dd, but not the part from
runtime-postinstall.tmpl :/

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list