[PATCH] rpmostreepayload: Avoid shutil.copytree in favor of cp -r to fix symlinks

Colin Walters walters at verbum.org
Wed Dec 3 14:18:15 UTC 2014

On Wed, Dec 3, 2014, at 08:57 AM, David Cantrell wrote:
> shutil.copytree(srcpath, destpath, symlinks=True)

I mentioned this in the commit message:

"Since we're shelling out to 'cp' in a case above, might as well do it here."

The reason for using 'cp' is coreutils has a desired behavior for EFI where if the target directory already exists (as a mount point in that case), that's not an error.

Also another rationale from the commit message:

"This also means that if we hit e.g. ENOSPC we'll enter the error
handling codepath instead of an uncaught traceback."

More information about the anaconda-patches mailing list