[master/f21-branch][PATCH] Make Python's default encoding detection work on Live installations (#1169019)

Adam Williamson awilliam at redhat.com
Tue Dec 2 01:25:33 UTC 2014

On Mon, 2014-12-01 at 10:00 -0500, David Shea wrote:
> On 12/01/2014 08:50 AM, Vratislav Podzimek wrote:
> > On Mon, 2014-12-01 at 08:39 -0500, David Shea wrote:
> >> On 12/01/2014 07:46 AM, Vratislav Podzimek wrote:
> >>> If LC_ALL is not defined, Python's detection of default encoding gives us
> >>> 'ascii' as the default codec on Live installations. Setting LC_ALL to $LANG
> >>> makes it work better and give us 'utf-8'.
> >>>
> >>> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> >>> ---
> >>>
> >> We don't set $LC_ALL on non-live, either. What is this trying to fix?
> > For some reason, the default encoding detection works on non-live (gives
> > 'utf-8'). This makes it work on Live as well.
> >
> Well that's weird. But if it works, sure, ack.

It might work to fix the crashes, hell if I know, but it's not viable,
because it causes another problem: it results in translations not being
properly displayed. Even though 21.48-20 fixes the .mo files so the full
translations are available, if you run a live install with 21.48-20 and
pick a non-English language, large chunks of the UI aren't translated.

This change appears to be the culprit; setting LC_ALL as an env var when
running liveinst seems to 'lock in' most of the strings so they're
displayed in that language no matter what language you pick on the
Welcome screen. See recent comments on
https://bugzilla.redhat.com/show_bug.cgi?id=1169019 and
https://bugzilla.redhat.com/show_bug.cgi?id=1169023 .
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net

More information about the anaconda-patches mailing list