[f21-branch][PATCH] clean up stage1 volume check, check format as well as mountpoint

Adam Williamson awilliam at redhat.com
Mon Dec 1 22:44:06 UTC 2014

On Mon, 2014-12-01 at 15:29 -0500, Anne Mulhern wrote:
> Newest version of patch attached.
> Basic changes from previous are:
> * Don't bother to sorts disk names before passing to set().
> * Only calculate s1disks if needed for designating bootDrive.
> * Don't sort the disks since we only need a best.
> * Treat constraints as if they are orthogonal, in case sometime it turns out
> that they are.
> Assumes that disks has at least one element; so did the previous code.

AFAICT the practical effect of this is the same as my v2 (and, in any
real-world case, the same as v1, unless someone can find a way to make
the stage1 target mount point be on a hidden or protected disk). I'm
obviously not really qualified to evaluate Anne's
refinements/adjustments to my implementation, but I can certainly say I
have no objections to any of it that I can see.
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net

More information about the anaconda-patches mailing list