[f21-branch][PATCH] clean up stage1 volume check, check format as well as mountpoint
awilliam at redhat.com
Mon Dec 1 16:26:17 UTC 2014
On Mon, 2014-12-01 at 10:48 -0500, Anne Mulhern wrote:
> I do see that disk_names is accessed later on in the execute
> method, so the sorting does make a difference. OTOH, the line of code
> that gets the value from disk_names by position was committed early
> in 2012, and was not influenced by the previous version of this patch.
I'm pretty sure it was, I did test it quite carefully. The previous
version defined 'disks' as 'all disks with valid stage1 target volumes'
if there were any, or simply disks = storage.disks if not. Then it
changed the disk_names list comprehension to:
disk_names = [d.name for d in disks...]
so that disk_names would be a disk with a valid stage1 target volume,
if there were any, or the same as before (first selected disk that isn't
an iSCSI disk on s390, basically) if not. *Probably* there wouldn't have
been any real-world case where the practical results of the two
approaches differ, but the second one is clearly less theoretically
likely to result in problematic behaviour.
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
More information about the anaconda-patches