[PATCH] installclass: Look for product.img in /run/product, not /tmp

Radek Vykydal rvykydal at redhat.com
Mon Dec 1 14:07:41 UTC 2014


On 12/01/2014 04:39 AM, Colin Walters wrote:
> TL;DR: Unpacking updates content into /tmp cannot have worked since
> systemd switched to tmp-on-tmpfs by default.  Use /run instead.
>
> As far as I can tell, the /tmp/product bit was introduced with
> https://git.fedorahosted.org/cgit/anaconda.git/commit/?id=459119c94529602d08de465b7ebfa4871d328081
>
> Maybe something was actually using it at the time?  Hard to know.
> Even then, I suspect all uses of product.img didn't modify
> installclasses.
>
> But currently with Atomic, I need a standalone ISO with different
> partitioning defaults.  Thererefore, let's fix this and look in
> /run/product, and I'll adjust my product.img to drop installclass data
> there.

Looking at this snippet from anaconda


         # Look for updates to the stylesheet and apply them at a higher 
priority
         for updates_dir in ("updates", "product"):
             updates_css = "/run/install/%s/anaconda-gtk.css" % updates_dir
             if os.path.exists(updates_css):
                 provider = Gtk.CssProvider()
                 provider.load_from_path(updates_css)
Gtk.StyleContext.add_provider_for_screen(Gdk.Screen.get_default(), provider,
                         STYLE_PROVIDER_PRIORITY_UPDATES)

shouldn't it be /run/install/product ?



More information about the anaconda-patches mailing list