[f21/master] Let gtk determine the allocation for overlays.

Vratislav Podzimek vpodzime at redhat.com
Thu Aug 28 07:30:23 UTC 2014


On Wed, 2014-08-27 at 18:04 -0400, David Shea wrote:
> We need to know the GtkOverlay's allocation at overlay time so that we can
> scale the overlay image, but we don't actually need to create the
> allocation for the overlay image. Gtk can do that on its own just fine.
> ---
>  pyanaconda/ui/gui/__init__.py | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/pyanaconda/ui/gui/__init__.py b/pyanaconda/ui/gui/__init__.py
> index c3a7705..952b5da 100644
> --- a/pyanaconda/ui/gui/__init__.py
> +++ b/pyanaconda/ui/gui/__init__.py
> @@ -322,13 +322,7 @@ class MainWindow(Gtk.Window):
>          overlayed_widget.set_from_pixbuf(self._transparent_base.scale_simple(
>              overlay_allocation.width, overlay_allocation.height, GdkPixbuf.InterpType.NEAREST))
>  
> -        # Set the allocation for the overlayed image to the full size of the GtkOverlay
> -        allocation.x = 0
> -        allocation.y = 0
> -        allocation.width = overlay_allocation.width
> -        allocation.height = overlay_allocation.height
> -
> -        return True
> +        return False
Why the return value changes here? Could you please add a comment about
its meaning? ACK otherwise.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list