[f21/master] Remove anaconda_make_pixbuf

David Shea dshea at redhat.com
Wed Aug 27 11:35:14 UTC 2014


On 08/27/2014 02:47 AM, Vratislav Podzimek wrote:
> Looks good to me, just one minor request -- could you please add a
> comment explaining the parameters passed to new_from_bytes? They were
> quite cryptic before and now there is an extra magic '8'.

Heh, sure. The annoying thing is that I'm pretty sure anything other 
than an 8 would break gdk-pixbuf, and the other extra parameter, the 
colorspace, is a value from an enumeration of one.

The parameters are data, colorspace, has-alpha, bits-per-sample (the 
mystery 8), width, height, and rowstride (number of bytes between row 
starts). I'll add that in a comment.


More information about the anaconda-patches mailing list