[anaconda][rhel7-branch][PATCH 00/14] Document Anaconda CLI options & improve option handling (#1088459)

Anne Mulhern amulhern at redhat.com
Fri Aug 22 13:15:13 UTC 2014





----- Original Message -----
> From: "Martin Kolman" <mkolman at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Thursday, August 21, 2014 4:10:21 PM
> Subject: [anaconda][rhel7-branch][PATCH 00/14] Document Anaconda CLI options &	improve option handling (#1088459)
> 
> A while ago I asked on our IRC channel how to go about backporting the
> patches that add help texts to all Anaconda boot options and also generally
> improve our CLI option handling. The general consensus was that I should try
> to backport as much of the improvements as possible - so here it is! :)
> 
> I've started by backporting the 20+ patches to rhel7-branch, followed
> by aggressive reordering and squashing, with the aim of squashing
> related stuff (all help texts in a single patch, all option removals
> in one patch, etc.) and giving the set a logical order (removals before
> adding help texts and booleanizing flag assignments, etc.).
> After defusing a lot of amusing merge conflicts I got this 14-piece patch
> set. :)
> 
> Strictly speaking only the patches that add the help texts and the fix for
> help text parsing
> are needed to satisfy the requirements of fixing bug 1088459, but the rest
> improve our
> option handling quite a lot and also harmonize it with what we have in Fedora
> right now
> (argparse, version detection, flags are bools, etc.) - this should make
> option related
> backports easier in the future.
> 
> Also, any opinions on removing the disused options vs the rhel7 lifecycle ?
> Most of these options haven't been doing anything for ages, so if they are
> passed as boot options, they will continue to do just that - Anaconda ignore
> them
> as unknown options. If they are passed on CLI, there might be change in
> behavior (Anaconda reporting the option is unknown) instead of accepting
> the option but not doing anything with it.
> 
> 
> 
> Brian C. Lane (1):
>   Fix --kickstart option
> 
> David Shea (2):
>   Allow the location of anaconda_options.txt to be overridden
>   Add anaconda_options.txt to makeupdates
> 
> Martin Kolman (10):
>   Return CLI help text at once
>   Don't overwrite function argument when parsing help texts
>   Switch Anaconda to argparse
>   Format the help text to properly fit to the terminal window
>   Parse boot options before parsing CLI options (#1101341)
>   Short-circuit initialization when printing out Anaconda version
>   Move Anaconda version detection from isys to Python code
>   Remove obsolete and disused Anaconda options
>   Use booleans and direct assignments for flags
>   Add help texts to Anaconda CLI options
> 
> Vratislav Podzimek (1):
>   Move the Anaconda class to a proper module
> 
>  .gitignore                      |   1 +
>  anaconda                        | 289 +++++++++++++++++----------------
>  configure.ac                    |   1 +
>  data/anaconda_options.txt       | 202 +++++++++++++++++++++++
>  docs/driverdisc.txt             |   4 +-
>  pyanaconda/Makefile.am          |   6 +-
>  pyanaconda/__init__.py          | 229 --------------------------
>  pyanaconda/anaconda.py          | 230 ++++++++++++++++++++++++++
>  pyanaconda/anaconda_argparse.py | 346
>  ++++++++++++++++++++++++++++++++++++++++
>  pyanaconda/anaconda_optparse.py | 249 -----------------------------
>  pyanaconda/exception.py         |   4 +-
>  pyanaconda/flags.py             |  18 +--
>  pyanaconda/isys/Makefile.am     |   3 +-
>  pyanaconda/isys/__init__.py     |   4 +-
>  pyanaconda/isys/isys.c          |   6 -
>  pyanaconda/startup_utils.py     |  80 ++++++++++
>  pyanaconda/version.py.in        |   1 +
>  scripts/makeupdates             |   2 +
>  18 files changed, 1023 insertions(+), 652 deletions(-)
>  create mode 100644 pyanaconda/anaconda.py
>  create mode 100644 pyanaconda/anaconda_argparse.py
>  delete mode 100644 pyanaconda/anaconda_optparse.py
>  create mode 100644 pyanaconda/startup_utils.py
>  create mode 100644 pyanaconda/version.py.in
> 
> --
> 1.9.3
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

I would squash patch (7) onto patch (2) if it wasn't too difficult on
the principle that they touch the same code and are the same basic idea,
"exit early".

Otherwise, looks good to me, and thanks.

- mulhern


More information about the anaconda-patches mailing list