[pykickstart:master] Move some statically detectable kickstart errors out of anaconda (#1117908)

Chris Lumens clumens at redhat.com
Wed Aug 20 20:53:05 UTC 2014


> diff --git a/pykickstart/commands/logvol.py b/pykickstart/commands/logvol.py
> index f8d571a..9d96aea 100644
> --- a/pykickstart/commands/logvol.py
> +++ b/pykickstart/commands/logvol.py
> @@ -472,4 +472,12 @@ class F20_LogVol(F18_LogVol):
>              errorMsg = _("The logvol and autopart commands can't be used at the same time")
>              raise KickstartParseError(formatErrorMsg(self.lineno, msg=errorMsg))
>  
> +        if not retval.preexist and not retval.percent and not retval.size:
> +            errorMsg = _("No size given for logical volume \"%s\". Use one of --useexisting, --noformat, --size, or --percent." % self.name)

Remember to do % outside of _() or the result will be a string that
cannot ever be translated.  Like this:

_("Whatever %s") % self.thing

- Chris


More information about the anaconda-patches mailing list