[master 0/4] Poke at iutil.execReadlines

Vratislav Podzimek vpodzime at redhat.com
Tue Aug 12 06:59:29 UTC 2014


On Fri, 2014-08-08 at 15:32 -0400, David Shea wrote:
> Maybe this is why anaconda-yum gets stuck sometimes? I don't know. I just
> figure a thread can't starve if there ain't no thread, so this gets rid of
> a thread and adds some tests to make sure I didn't break things too badly.
I still don't understand the reason for removing the thread. I think it
is better to just pull out the output of the process and let it
terminate ASAP even if our processing takes longer. Is it only because
it's simpler and easier to debug or python's problematic signal
handling?
Which brings me to another question -- what happens if our code doesn't
read all the output from the process? Does it even terminate? We should
have a test case for that as well as I think it is a completely valid,
useful and used usecase (use, use, use :)).

The patches 1/4-3/4 look good to me with the one minor comment on 2/4.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list