[blivet:master 0/9] mdadd fixing patch set (v2)
mulhern
amulhern at redhat.com
Mon Aug 4 15:56:52 UTC 2014
The new or interesting ones start with "Omit unnecessary..."
The treatment of has_redundancy has changed from previous version.
The dynamically generated classes to test adding and growing for different
levels may seem a bit wierd, but there are two reasons for this:
*) Python has what looks like unnecessary boilerplate for dynamic class
generation so it looks worse than it is.
*) I wracked my brain for a better way, but if you want to make use of all
the unittest infrastructure, then each of the tests has to be a class that
extends LoopBackedTestCase. Ideally, there would be someway to use a context
manager instead, but it is very hard to come up with that way within the
unittest infrastructure.
mulhern (9):
Fix mdnominate error message.
Use long messages for unittest errors.
Still attempt to destroy even if remove failed.
Add a test for mddetail on containers.
Add a test for activation.
Omit unnecessary class hierarchy related boilerplate.
Make has_redundancy a method rather than a property.
Revise mdadd.
Add a bunch of tests for mdadd.
blivet/devicelibs/mdraid.py | 30 ++--
blivet/devicelibs/raid.py | 49 ++++--
blivet/devices.py | 23 ++-
tests/devicelibs_test/mdraid_interrogate_test.py | 22 ++-
tests/devicelibs_test/mdraid_test.py | 210 ++++++++++++++++++-----
tests/formats_test/labeling_test.py | 21 ---
tests/pylint/pylint-false-positives | 1 +
7 files changed, 255 insertions(+), 101 deletions(-)
--
1.9.3
More information about the anaconda-patches
mailing list