[blivet] unit test updates

Anne Mulhern amulhern at redhat.com
Fri Aug 1 09:56:44 UTC 2014





----- Original Message -----
> From: "Brian C. Lane" <bcl at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Friday, August 1, 2014 2:20:54 AM
> Subject: Re: [blivet] unit test updates
> 
> On Thu, Jul 31, 2014 at 05:16:18PM -0500, David Lehman wrote:
> > Prompted by jenkins, I ran blivet's unit tests as root in a vm and here
> > is what I had to do to make it run, aside from applying my recent
> > pyparted patch to the code in python's site-lib.
> > 
> > Patch 2 is old code that I've wanted to remove for some time now, which I
> > found was getting triggered erroneously when manipulating a container's
> > member set as part of the action tests.
> > 
> > David Lehman (4):
> >   Bypass size getter when mocking new devices.
> >   Remove unused lvm and md activation code.
> >   Clean up mocking done by udev tests when finished.
> >   Update selinux tests for default context of mounts under /tmp.
> > 
> >  blivet/devices.py                  | 20 --------------------
> >  tests/formats_test/selinux_test.py |  6 +++---
> >  tests/storagetestcase.py           |  2 +-
> >  tests/udev_test.py                 | 12 ++++++++++--
> >  4 files changed, 14 insertions(+), 26 deletions(-)
> > 
> > --
> > 1.9.3
> 
> ACK
> 
> --
> Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA
> (PST8PDT)
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

These seem fine to me.

Note that with the change, we lose the only use of mdnominate within the
blivet code base. IMHO, tt's a toss-up whether the definition of mdnominate
should be removed or not, but I thought I'ld mention it.

- mulhern


More information about the anaconda-patches mailing list