[blivet] Drop our pyudev in favor of python-udev (v2)

Brian C. Lane bcl at redhat.com
Fri Aug 1 00:27:50 UTC 2014


On Thu, Jul 31, 2014 at 06:22:28PM -0500, David Lehman wrote:
> Previous patch 3 is now part of a separate set.
> 
> Patch 1 has the suggested fixes from the list as well as conversion of
> new logging statements in StorageDevice.updateSysfsPath to pass arguments
> separately instead of formatting the string in advance.
> 
> Patch 2 has added comment disabling pylint warning about defining _mdInfo
> outside of __init__.
> 
> Patch 3 (separate lvm and md metadata...) has added disabling of pylint
> warnings for unused argument 'info'.
> 
> Patch 4 (adapt multipath...) is unchanged.
> 
> Patch 5 is new and just removes some things no longer used.
> 
> Patch 6 is also new and removes a function that is no longer useful.
> 
> David Lehman (6):
>   Replace our pyudev with the package python-pyudev.
>   Cache MD metadata while populating the devicetree.
>   Keep lvm and md metadata separate from udev info.
>   Adapt multipath detection code to external pyudev module.
>   Remove some unused multipath-specific functions from blivet.udev.
>   Remove parse_uevent_file since it won't work with pyudev.
> 
>  blivet/deviceaction.py |   4 +-
>  blivet/devices.py      |  95 +++++++--------------
>  blivet/devicetree.py   | 122 ++++++++++++++------------
>  blivet/pyudev.py       | 226 -------------------------------------------------
>  blivet/udev.py         | 145 ++++++++-----------------------
>  blivet/util.py         |   2 +-
>  python-blivet.spec     |   1 +
>  tests/udev_test.py     | 130 +---------------------------
>  8 files changed, 143 insertions(+), 582 deletions(-)
>  delete mode 100644 blivet/pyudev.py
> 
> -- 
> 1.9.3

These look OK to me other than my 1 question.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list