[blivet:master 08/12] Disable unused argument warning for 'b' in create_sparse_file

Anne Mulhern amulhern at redhat.com
Wed Apr 30 12:34:36 UTC 2014


----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Tuesday, April 29, 2014 2:36:09 PM
> Subject: Re: [blivet:master 08/12] Disable unused argument warning for 'b'	in create_sparse_file
> 
> 
> 
> On 04/29/2014 12:01 PM, Brian C. Lane wrote:
> > On Mon, Apr 28, 2014 at 06:26:46PM -0400, mulhern wrote:
> >> This allows this method to have a uniform interface with print_devices
> >> and tear_down_disk_images in the same file.
> >>
> >> It's somewhat off-putting that anaconda has dependencies on methods that
> >> are
> >> in the blivet examples directory, but it depends on both
> >> create_sparse_file
> >> and tear_down_disk_images in common.py.
> >
> > That's something we should fix. In the anaconda test it is doing:
> > execfile("/usr/share/doc/python-blivet/examples/common.py")
> >
> > so it is depending on something installed on the host that may or may
> > not match the tree.
> >
> > Maybe move those from examples into blivet/util.py?
> 
> I happen to have made such a patch last week:
> 
> http://dlehman.fedorapeople.org/patches/20140424-test-branch.3/0008-Move-set_up_logging-and-create_sparse_file-into-bliv.patch
> 
> http://dlehman.fedorapeople.org/patches/20140424-test-branch.3/0009-Change-devices.SparseFileDevice._create-to-use-util..patch
> 
> I'll hopefully be posting that set for review sometime this week.
> 
> David
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

I'm pulling this patch from the patch set.

- mulhern


More information about the anaconda-patches mailing list