[blivet:master 04/12] Use values for keyword arguments to CryptSetup.

Anne Mulhern amulhern at redhat.com
Wed Apr 30 12:14:20 UTC 2014





----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Tuesday, April 29, 2014 3:09:23 AM
> Subject: Re: [blivet:master 04/12] Use values for keyword arguments to	CryptSetup.
> 
> On Mon, 2014-04-28 at 18:26 -0400, mulhern wrote:
> > Do not bother to give the values names.
> This change brings one potential issue -- if we wanted to start passing
> e.g. some real logging function ot cryptsetup we would have to change it
> in many places. I'd prefer giving those lambdas names and having them as
> constants at the top of the module.
> 
> --
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Ok.

Removing from this patch set.

- mulhern


More information about the anaconda-patches mailing list