[blivet:master 00/12] Maybe two more sets to go after this one

Vratislav Podzimek vpodzime at redhat.com
Tue Apr 29 07:12:14 UTC 2014


On Mon, 2014-04-28 at 18:26 -0400, mulhern wrote:
> These are all short, and the details are obvious,
> it's a question of whether the patch makes the correct 
> decision or not, mostly when it comes to the "Disable..." patches.
> 
> mulhern (12):
>   Remove obsolete comment
>   Changes to _parseOneLine() and its single invocation.
>   Get rid of unused argument 'args' in MakeBumpVer constructors
>   Use values for keyword arguments to CryptSetup.
>   Disable a no member warning for EddTestFS initializer.
>   Remove pointless parameters from unittest methods.
>   Disable unused argument warning for 'disks' in get_pv_space.
>   Disable unused argument warning for 'b' in create_sparse_file
>   Disable unused argument warning for 'info' in handleUdevLuksFormat
>   Disable unused argument warning for 'data' in doAutoPartition
>   Disable unused argument warning for 'del_passphrase' in
>     luks_remove_key
>   Disable unused argument warning for 'key_file' in devicelibs.crypto
>     methods
> 
>  blivet/__init__.py                | 19 +++++++++++--------
>  blivet/devicelibs/crypto.py       | 31 ++++++++++++-------------------
>  blivet/devicelibs/lvm.py          |  1 +
>  blivet/devices.py                 |  6 +-----
>  blivet/devicetree.py              |  1 +
>  blivet/partitioning.py            |  1 +
>  examples/common.py                |  1 +
>  scripts/makebumpver               |  2 +-
>  tests/action_test.py              | 12 ++++++------
>  tests/devicelibs_test/edd_test.py |  2 +-
>  tests/devices_test.py             |  8 ++++----
>  11 files changed, 40 insertions(+), 44 deletions(-)
Other than that one minor comment these all look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list