[PATCH] Check the right button when saving changes in the Custom spoke (#1090786)

Vratislav Podzimek vpodzime at redhat.com
Mon Apr 28 15:17:15 UTC 2014


On Mon, 2014-04-28 at 07:55 -0400, Anne Mulhern wrote:
> 
> 
> 
> ----- Original Message -----
> > From: "Vratislav Podzimek" <vpodzime at redhat.com>
> > To: anaconda-patches at lists.fedorahosted.org
> > Sent: Monday, April 28, 2014 5:33:01 AM
> > Subject: [PATCH] Check the right button when saving changes in the Custom	spoke (#1090786)
> > 
> > When saving changes we should check if the "Update settings" button is
> > sensitive
> > (i.e. any change to be saved) not the add button.
> > 
> > Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> > ---
> >  pyanaconda/ui/gui/spokes/custom.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/pyanaconda/ui/gui/spokes/custom.py
> > b/pyanaconda/ui/gui/spokes/custom.py
> > index cb3a2de..83a2d1c 100644
> > --- a/pyanaconda/ui/gui/spokes/custom.py
> > +++ b/pyanaconda/ui/gui/spokes/custom.py
> > @@ -836,7 +836,7 @@ class CustomPartitioningSpoke(NormalSpoke,
> > StorageChecker):
> >          # only call _save_right_side if on the right page and some changes
> >          need
> >          # to be saved (sensitivity of the Update Settings button reflects
> >          that)
> >          if self._partitionsNotebook.get_current_page() !=
> >          NOTEBOOK_DETAILS_PAGE or \
> > -           not self._addButton.get_sensitive():
> > +           not self._applyButton.get_sensitive():
> >              return
> >  
> >          device = selector.device
> > --
> > 1.9.0
> > 
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> 
> I'ld change the title of the commit message to "Check the correct button...",
> otherwise Ack.
Fixed in local copy.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list