[blivet:master 00/13] Still almost the last pylint patches
Martin Kolman
mkolman at redhat.com
Fri Apr 25 13:48:34 UTC 2014
On Fri, 2014-04-25 at 08:54 -0400, mulhern wrote:
> I hope there will be no more than two more sets.
>
> None of these are particularly interesting, all are short except the last.
>
> mulhern (13):
> Prefix name with defining package
> Suppress unpacking-non-sequence pylint warning
> Set child_factory_fstype to None in DeviceFactory
> Disable not-callable pylint warning.
> Remove minimumSector method and _minimumSector attribute
> Simplify call to _parseOneLine() and suppress warning about unused
> argument
> Pass fname as first argument to shutil.copy2
> Actually use argv parameter
> Make signature of _setSize match that of the method it overrrides.
> Removed unused argument 'options' from testMount
> Remove unused parameter in makeupdates.
> Change name to avoid redefining built-in
> Rename to avoid redefining parameter built-ins
>
> blivet/__init__.py | 12 +++++-------
> blivet/devicefactory.py | 3 ++-
> blivet/devices.py | 20 ++++++++++----------
> blivet/devicetree.py | 2 +-
> blivet/formats/fs.py | 2 +-
> blivet/platform.py | 6 ------
> blivet/size.py | 4 ++--
> blivet/zfcp.py | 36 ++++++++++++++++++------------------
> scripts/makebumpver | 6 +++---
> scripts/makeupdates | 12 ++++++------
> tests/size_test.py | 22 +++++++++++-----------
> tests/storagetestcase.py | 8 ++++----
> 12 files changed, 63 insertions(+), 70 deletions(-)
>
These all look good to me, thanks, ACK!
More information about the anaconda-patches
mailing list