[PATCH] iutil: Introduce getSysroot()/getTargetPhysicalRoot(), use instead of ROOT_PATH

Vratislav Podzimek vpodzime at redhat.com
Thu Apr 24 05:59:16 UTC 2014


On Wed, 2014-04-23 at 21:10 +0000, Colin Walters wrote:
> On Wed, Apr 23, 2014 at 2:47 AM, Vratislav Podzimek
> <vpodzime at redhat.com> wrote:
> > I'm sorry, but I don't quite get this. The docstring says, this can
> > return something different from the sysroot and the only thing it
> > does is returning the value of getSysroot().
> 
> Right.  This attached patch fixes it to return a constant ROOT_PATH -
> we never want to mount the storage anywhere else really.
> 
> 
> However I think it's worth having a new function because it allows us
> to "git grep ROOT_PATH" and find any locations that need to be
> changed.
> 
> 
> Also, I took this opportunity to introduce setSysroot() which was in a
> later patch.
> 
> 
> New patch attached, thanks for the review!
This looks good to me. Unless somebody finds something problematic in
it, I'm gonna push this tomorrow.


-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list