[blivet] md followups to recent changes and one more
Anne Mulhern
amulhern at redhat.com
Tue Apr 22 17:40:03 UTC 2014
----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Tuesday, April 22, 2014 12:09:03 PM
> Subject: Re: [blivet] md followups to recent changes and one more
>
> On Tue, 2014-04-22 at 10:25 -0500, David Lehman wrote:
> > Patch 1 fixes a bug I introduced with the container device class.
> >
> > Patches 2 and 3 fix long-standing bugs related to detection of existing
> > MD.
> >
> > Patch 4 is a followup to make lvm data caching work with MD PVs.
> >
> > Patch 5 is unrelated, and makes it so that merely instantiating an action
> > does not change the device instance it will operate on.
> >
> >
> > blivet/deviceaction.py | 106
> > +++++++++++++++++++++++++++++++++++++++++++----
> > blivet/devicelibs/lvm.py | 11 +++--
> > blivet/devices.py | 12 ++++--
> > blivet/devicetree.py | 10 ++++-
> > tests/action_test.py | 55 ++++++++++++++++++++----
> > 5 files changed, 170 insertions(+), 24 deletions(-)
> Other than those two rather neat-picks these all look good to me.
>
> --
> Vratislav Podzimek
>
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
>
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
>
No more comments for this patch set from me.
- mulhern
More information about the anaconda-patches
mailing list