[PATCH 0/7] Input validation on the source spoke

David Shea dshea at redhat.com
Thu Apr 17 13:07:56 UTC 2014


On 04/17/2014 06:32 AM, Martin Kolman wrote:
> On Tue, 2014-04-15 at 14:22 -0400, David Shea wrote:
>> Convert the existing checks to InputCheck checks, and add checks for everything
>> else. The patch removing the labels used for the existing addon repo checks is
>> a separate patch in case that turns out to be controversial. If we want, those
>> labels can stay and be updated by overriding set_status in SourceSpoke, but I
>> figured I'd put all the messages in the info bar for consistency (and because
>> it was easier).
>>
>> David Shea (7):
>>    Added a link to a bug about the user data in glade problem.
>>    Use ID columns in the protocol combo boxes
>>    Add a remove_check method for InputCheckHandler.
>>    Convert the repository name test into a regex
>>    Expand the proxy URL validation.
>>    Remove the tests for duplicate and invalid repo names
>>    Add input validation to the source spoke.
>>
>>   pyanaconda/regexes.py                 |   4 +
>>   pyanaconda/ui/gui/spokes/source.glade | 130 ++---------
>>   pyanaconda/ui/gui/spokes/source.py    | 403 ++++++++++++++++++++++++----------
>>   pyanaconda/ui/helpers.py              |  16 +-
>>   tests/regex_tests/repo_name_test.py   |  66 ++++++
>>   5 files changed, 387 insertions(+), 232 deletions(-)
>>   create mode 100644 tests/regex_tests/repo_name_test.py
>>
> I've git am-ed the patches and found a single issue - if the repository
> URL is empty, no error is shown but clicking "done" will not let you out
> of the spoke until you either set a patch or remove the repository.
> I guess this might be rather confusing for users.
>
> Other than that the patches seem work fine and to really improve the
> source & proxy address validation robustness, so ACK  provided the above
> mentioned issue is addressed. :)
>
>

I used a silent error for empty URLs in the proxy dialog, since you can 
still hit cancel there if the URL is empty. I agree, though, it's 
confusing in the spoke itself. I'll change that to set a warning message.


More information about the anaconda-patches mailing list