[PATCH 11/11] Add the beginnings of an automated GUI test suite.

Chris Lumens clumens at redhat.com
Tue Apr 8 14:24:51 UTC 2014


> > +    def exit_spoke(self, hubName="INSTALLATION SUMMARY"):
> > +        """Leave a spoke by clicking the Done button in the upper left corner,
> > +           then verify we have returned to the proper hub.  Since most spokes
> > +           are off the summary hub, that's the default.  If we are not back
> > +           on the hub, the current test case will be failed.
> > +        """
> > +        button = self.find("Done", "button")
> > +        self.assertIsNotNone(button, msg="Done button not found")
> > +        button.click()
> > +        doDelay(5)
> I'm afraid this may be not enough. I've definitely seen the grey screen
> instead of hub for more than 5 seconds on my VMs.

We should investigate why this is happening and fix it.

> > +    def _timer_expired(self):
> This should take signum and frame arguments.
> (https://docs.python.org/2/library/signal.html#signal.signal)

Done.

> > +    def _timer_expired(self):
> Same here.

And done.

> > +        button = self.find("I would lke to make additional space available.", "button")
> TYPO:                                  ^^ like

Fixed.

> > +    def check_shown_spoke_selectors(self):
> > +        # FIXME:  This forces English.
> > +        validSelectors = ["DATE & TIME", "KEYBOARD", "INSTALLATION DESTINATION", "NETWORK & HOSTNAME"]
> How does those ampersands work with the & entities used in the
> previous patches?

It appears to work.  The & business is in those patches because I
just copied what we're doing in the glade file.  I do not remember why
we used it in the first place there.

> > +        # pylint: disable-msg=E0602
> > +        disk1_path = create_sparse_file(b, "suite", blivet.size.Size(spec="11Mb"))
> I guess it means the same in blivet, but this should probably be 11 MB^^

Done.

> > +            part = b.newPartition(size=blivet.size.Size(spec="10Mb"), parents=[disk1])
> Same on this line.

And done.

- Chris


More information about the anaconda-patches mailing list