[master] Another batch for the Custom spoke
Martin Kolman
mkolman at redhat.com
Mon Apr 7 11:52:28 UTC 2014
On Fri, 2014-04-04 at 21:54 +0200, Vratislav Podzimek wrote:
> This time a bit heavier. Before pointing out that the PATCH 2/5 is crazy and
> duplicates a lot of stuff, please have a look at the PATCH 3/5 which facilitates
> things quite a lot.
>
> The overall goal of these patches and some other that will follow next week is
> to make the _save_right_side method less complex and shorter.
>
> Vratislav Podzimek (5):
> Mountpoint validation should only care about the new fs type
> Move code attempting to replace device into a separate function
> Pass information about old and new device as a dictionary
> Do device change logging in one place where possible
> Comment the part of the code changing an existing device
>
> pyanaconda/ui/gui/spokes/custom.py | 190 ++++++++++++++++++++-----------------
> 1 file changed, 102 insertions(+), 88 deletions(-)
>
Other than that little nitpick/question the patch batch looks good, so
ACK from me. :)
More information about the anaconda-patches
mailing list