[blivet:master 0/9] A bunch of miscellaneous pylint patches

Vratislav Podzimek vpodzime at redhat.com
Fri Apr 4 16:54:56 UTC 2014


On Thu, 2014-04-03 at 13:32 -0400, mulhern wrote:
> Just a bunch of small, reasonably self-contained pylint patches.
> 
> mulhern (9):
>   Remove all references to lvm_vg_blacklist and blacklistVG.
>   Obvious fix inspired by an "Undefined variable warning"
>   Remove unnecessary lambda wrappers on assertion functions
>   Make sure _state_functions is a dictionary in base class
>   Use self.nic instead of nic
>   Suppress false positive W0631 error.
>   Make LabelingAsRoot class an abstract class and define two properties
>   Add a bunch of E1120 errors to the false positives file
>   Ignore E1101 errors in savePassphrase.
> 
>  blivet/__init__.py                  |  2 --
>  blivet/devicefactory.py             |  2 +-
>  blivet/devicelibs/lvm.py            |  6 ------
>  blivet/devices.py                   |  4 ++--
>  scripts/makebumpver                 |  1 +
>  tests/devices_test.py               |  6 +++---
>  tests/formats_test/fslabeling.py    |  9 +++++++++
>  tests/formats_test/labeling_test.py | 30 ++++++++++++++++++------------
>  tests/pylint/pylint-false-positives |  4 ++++
>  9 files changed, 38 insertions(+), 26 deletions(-)
These all look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list