[PATCH 06/10] Make exception handling more specific

David Shea dshea at redhat.com
Thu Sep 26 12:59:21 UTC 2013


On 09/25/2013 05:59 PM, Brian C. Lane wrote:
>> >-    except Exception as e:
>> >+    except YumBaseError as e:
>> >          print("ERROR: transaction error: %s" % e)
>> >      finally:
>> >          print("QUIT:")
> This is broad on purpose. We want to tell anaconda what the error is
> when it fails, not just die with a traceback. The caller is waiting for
> output from anaconda-yum and handling any errors that show up.
>
> If anything add another except Exception with a more generic error
> instead of transaction error.
>
Fair enough. I'll put the try: back where it was and add a handler and 
pylint exception for Exception. It should probably exit with a failure 
there, though, right?


More information about the anaconda-patches mailing list