[anaconda] Export the pykickstart Eula command

Vratislav Podzimek vpodzime at redhat.com
Tue Sep 24 12:30:55 UTC 2013


On Mon, 2013-09-23 at 14:31 -0400, Chris Lumens wrote:
> > diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> > index 05e855d..13160d9 100644
> > --- a/pyanaconda/kickstart.py
> > +++ b/pyanaconda/kickstart.py
> > @@ -625,6 +625,10 @@ class Lang(commands.lang.F19_Lang):
> >      def execute(self, *args, **kwargs):
> >          localization.write_language_configuration(self, ROOT_PATH)
> >  
> > +class Eula(commands.eula.F20_Eula):
> > +    # no overrides needed here
> > +    pass
> > +
> >  class LogVol(commands.logvol.F20_LogVol):
> >      def execute(self, storage, ksdata, instClass):
> >          for l in self.lvList:
> 
> You could simplify this to:
> 
> class Eula = commands.eula.F20_Eula
> 
> Though, you would still want to comment on it so we know what's going on
> here.  I don't guess we can just skip having to do this and have
> initial-setup look at pykickstart for the class, huh?
I changed the class definition locally, thanks. Having initial-setup
look at pykickstart for the class would mean it would need to look at
pyanaconda/kickstart overrides and then to look at pykickstart for
classes for the right release, which is something I'd really like to
avoid adding.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list