[master/rhel7-branch] Make it obvious user is going to begin installation in TUI. (#975793)
Vratislav Podzimek
vpodzime at redhat.com
Fri Sep 20 19:58:01 UTC 2013
On Fri, 2013-09-20 at 15:46 -0400, Samantha N. Bueno wrote:
> On Fri, Sep 20, 2013 at 11:28:37AM -0400, Vratislav Podzimek wrote:
> > On Fri, 2013-09-20 at 10:45 -0400, Samantha N. Bueno wrote:
> > > Re-post of a patch from forever ago that needed a little work. This
> > > should only require very minimal tweaking for rhel7-branch.
> > >
> > > This tweaks the global default prompt for the new option ('b' to
> > > begin installation), so it should now be very clear to users that they
> > > are about to kick off installation.
> > > This also adds a default prompt for spokes, as many of them need to have
> > > the 'c' to continue option, and it is probably best to just have 'b' to
> > > begin installation on the summary hub anyhow.
> > >
> > > End result looks like this:
> > > http://sbueno.fedorapeople.org/images/975793-revised.jpg
> > >
> > > Resolves: rhbz#975793
> > > ---
> > > pyanaconda/ui/tui/hubs/__init__.py | 2 +-
> > > pyanaconda/ui/tui/simpleline/base.py | 6 +++---
> > > pyanaconda/ui/tui/spokes/__init__.py | 10 ++++++++--
> > > pyanaconda/ui/tui/spokes/network.py | 3 +++
> > > 4 files changed, 15 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/pyanaconda/ui/tui/hubs/__init__.py b/pyanaconda/ui/tui/hubs/__init__.py
> > > index 8f219c3..be78b32 100644
> > > --- a/pyanaconda/ui/tui/hubs/__init__.py
> > > +++ b/pyanaconda/ui/tui/hubs/__init__.py
> > > @@ -109,7 +109,7 @@ class TUIHub(TUIObject, common.Hub):
> > > # If we get a continue, check for unfinished spokes. If unfinished
> > > # don't continue
> > > # TRANSLATORS: 'c' to continue
> > > - if key == _('c'):
> > > + if key == _('b'):
> > Don't forget to update the TRANSLATORS comment right above.
>
> Ah right, thanks for that.
>
> > Otherwise this looks good to me. Could you just please remind me why we
> > don't leave spokes and hubs in general use 'c' and 'continue' and just
> > override the SummaryHub's prompt and input methods to use 'b' and
> > 'begins installation'? Prompt could be overriden quite easily and the
> > input method could replace 'b' with 'c' (or more precisely their
> > translations). Wouldn't that work?
>
> There's no better reason logically, I just thought it was nicer to have
> things conform to defaults, even if it did involve adding a new default
> (e.g. default spoke prompt). I can re-write it to just have the custom
> prompt and input functions in the SummaryHub if you think that's better;
> I could go either way.
Thinking about addons or any additional hubs we may need in the future
that will probably not start the installation process, I think it would
be better to have the c/continue prompt by default and overriden just in
the Summary hub.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list