[PATCH 2/2] Render the right arrow based on the widget direction (#1008397)

Vratislav Podzimek vpodzime at redhat.com
Wed Sep 18 10:17:02 UTC 2013


On Tue, 2013-09-17 at 17:24 -0400, Chris Lumens wrote:
> > @@ -51,8 +51,11 @@ class LangLocaleHandler(object):
> >          self._localeSelection = None
> >  
> >      def initialize(self):
> > -        # Render a right arrow for the chosen language
> > -        self._right_arrow = Gtk.Image.new_from_file("/usr/share/anaconda/pixmaps/right-arrow-icon.png")
> > +        # Render an arrow for the chosen language
> > +        if get_default_widget_direction() == Gtk.TextDirection.LTR:
> > +            self._right_arrow = Gtk.Image.new_from_file("/usr/share/anaconda/pixmaps/right-arrow-icon.png")
> > +        else:
> > +            self._right_arrow = Gtk.Image.new_from_file("/usr/share/anaconda/pixmaps/left-arrow-icon.png")
> >          self._langSelectedColumn.set_cell_data_func(self._langSelectedRenderer,
> >                                                      self._render_lang_selected)
> 
> It'd be a little less confusing to just have the variable named
> self._arrow here, but ACK otherwise.
Good point, fixing locally.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list