[master] XklWrapper refactorization

David Shea dshea at redhat.com
Fri Sep 13 13:12:56 UTC 2013


On 09/13/2013 06:59 AM, Vratislav Podzimek wrote:
> These patches have one goal -- to avoid creating new instances of the XklWrapper
> class on language change because it is an expensive action. However, they also
> bring better code, more documentation, better "unittest test pontential" and
> altogether they are -2 lines of code.
>
> They apply to David Shea's patches for keyboard layouts and switching options
> translations because I'd like to keep track of the changes in our git history
> and it would also allow us to easily revert changes made here if there are any
> problems within.
>
> Vratislav Podzimek (4):
>    Remove the Layout class and things we don't need in XklWrapper
>    Move upcase_first_letter function to iutil
>    Improve XklWrapper's API
>    Translate layout and switching options descriptions on the fly
>
>   pyanaconda/iutil.py                  |  21 ++++++
>   pyanaconda/keyboard.py               | 122 +++++++++++++++++------------------
>   pyanaconda/localization.py           |  27 ++------
>   pyanaconda/ui/gui/spokes/keyboard.py |  18 +++---
>   4 files changed, 93 insertions(+), 95 deletions(-)
>
Besides my comment and your comment about _instance_lang, these look 
good to me


More information about the anaconda-patches mailing list