[PATCH 1/2] Don't set ksdata.lang.seen to True if using default value

Vratislav Podzimek vpodzime at redhat.com
Fri Sep 13 08:23:30 UTC 2013


On Thu, 2013-09-12 at 11:08 -0400, Chris Lumens wrote:
> > If setting kdsdata.lang.lang to the default value (DEFAULT_LANG),
> > don't set ksdata.lang.seen to True. Otherwise it would not be possible
> > to discern the default value from a value set by the user using
> > kickstart or a bootoption.
> > 
> > Also clean-up the language handling code a bit and remove
> > the default value setting in kickstart.py as it is no longer needed.
> 
> I don't see where you're avoiding setting ksdata.lang.seen.  Perhaps I
> am missing something, but it seems like either the commit message is
> wrong or there's a piece missing here.
It would require a wider context of the patch to make it clearer.
Without this patch the pyanaconda/kickstart.py:Keyboard class sets its
default value (due to the text mode) which results in the code in the
anaconda script taking it as a value set in the kickstart (because it
doesn't check ksdata.lang.seen only ksdata.lang.lang), using it as a
requested value and setting ksdata.lang.seen to True.

With this patch, the class itself doesn't set its default value and the
code in the anaconda script goes the other path, just setting
ksdata.lang.lang to the defautl (due to the text mode) and not setting
ksdata.lang.seen to True, which fixes a serious bug that caused all
installations working as if the language was set to the default value in
kickstart.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list