[PATCH 1/3] DNFPayload: select kernel packages.
Ales Kozumplik
akozumpl at redhat.com
Fri Sep 13 08:03:05 UTC 2013
On 09/12/2013 05:20 PM, Chris Lumens wrote:
>> diff --git a/pyanaconda/packaging/dnfpayload.py b/pyanaconda/packaging/dnfpayload.py
>> index 585d543..01584a1 100644
>> --- a/pyanaconda/packaging/dnfpayload.py
>> +++ b/pyanaconda/packaging/dnfpayload.py
>> @@ -121,6 +121,7 @@ class DNFPayload(packaging.PackagePayload):
>>
>> map(self._install_package, self._required_pkgs)
>> map(self._select_group, self._required_groups)
>> + self._select_kernel_package()
>>
>> def _bump_tx_id(self):
>> if self.txID is None:
>> @@ -181,6 +182,19 @@ class DNFPayload(packaging.PackagePayload):
>> types.add('optional')
>> self._base.select_group(grp, types)
>>
>> + def _select_kernel_package(self):
>> + kernels = self.kernelPackages
>> + for kernel in kernels:
>> + try:
>> + self._install_package(kernel)
>> + except packaging.NoSuchPackage:
>> + log.info('kernel: no such package %s', kernel)
>> + else:
>> + log.info('kernel: selected %s', kernel)
>> + break
>> + else:
>> + log.error('kernel: failed to select a kernel from %s', kernels)
>> +
>> def _sync_metadata(self, dnf_repo):
>> try:
>> dnf_repo.load()
>
> For parallelism, could you please also rename selectKernelPackage in
> yumpayload.py to _select_kernel_package? We don't ever call that
> outside of the class, so there's no need for it to have the public name.
>
Hm, OK.
More information about the anaconda-patches
mailing list