[PATCH 0/2] Move all langs from geoip to top in Welcome spoke and fix default lang setting

Vratislav Podzimek vpodzime at redhat.com
Thu Sep 12 12:29:52 UTC 2013


On Thu, 2013-09-12 at 12:55 +0200, Martin Kolman wrote:
> The first patch fixes how default language is set and also cleans up the default language
> setting code quite a bit.
> 
> The second patch moves all languages found for the given territory reported by GeoIP
> to the top of the language list, above the separator, as suggested during the usability testing[1].
> It also fixes locale variant preselection (so that for the GB territory, language is
> set to English, but locale to English(UK)). And finally the patch cleans-up the locale and language
> handling in Welcome spoke quite a bit.
> 
> [1] https://fedoraproject.org/wiki/Anaconda/UX_Redesign/Usability_Test_Suggestions#B._Language_Selection
> 
> 
> Martin Kolman (2):
>   Don't set ksdata.lang.seen to True if using default value
>   Move all languages found by geoip to the top in Welcome spoke
> 
>  anaconda                            |  3 +-
>  pyanaconda/kickstart.py             |  5 ---
>  pyanaconda/ui/gui/spokes/welcome.py | 70 +++++++++++++++++++++++++------------
>  3 files changed, 49 insertions(+), 29 deletions(-)
These both look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list