[PATCH v03] Clean up code for input handling in TUI spokes.

Vratislav Podzimek vpodzime at redhat.com
Wed Sep 11 08:15:17 UTC 2013


On Tue, 2013-09-10 at 14:54 -0400, Samantha N. Bueno wrote:
> This is just some clean-up that needed to get done:
> -- removes some unnecessary error catching
> -- fixes up some typos
> -- fixes some inconsistency with variable naming
> -- also adds a couple constants to make the end result of input processing
>    in the spokes less confusing
> ---
>  pyanaconda/constants_text.py           |  4 ++
>  pyanaconda/ui/tui/spokes/askvnc.py     | 13 +++--
>  pyanaconda/ui/tui/spokes/network.py    |  7 +--
>  pyanaconda/ui/tui/spokes/software.py   | 20 +++++---
>  pyanaconda/ui/tui/spokes/source.py     | 78 +++++++++++++++--------------
>  pyanaconda/ui/tui/spokes/storage.py    | 91 +++++++++++++++++-----------------
>  pyanaconda/ui/tui/spokes/time_spoke.py | 57 ++++++++++-----------
>  7 files changed, 142 insertions(+), 128 deletions(-)
This makes the code much clearer, thanks! Just please update the
pyanaconda/ui/tui/simpleline/base.py:UIObject.input method's docstring
to mention the new constants.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list